VED-788 Refactor ack_backend #844
Conversation
…immunisation-fhir-api into VED-788-refactor-ack-backend
…immunisation-fhir-api into VED-788-refactor-ack-backend
| ) | ||
|
|
||
|
|
||
| def move_file(bucket_name: str, source_file_key: str, destination_file_key: str) -> None: |
There was a problem hiding this comment.
Todo: this function and others like it are prime candidates to be refactored into a utils file e.g. shared/utils.py
I won't do this now, but when we refactor one of the other lambdas which has the identical function (e.g. filenameprocessor). There's a unit test for it (existing only in ack_backend!) which should move as well, with appropriate mocking
There was a problem hiding this comment.
Errors hadn't been covered with their own unit tests at all - just by tests in other modules. This was an omission in code coverage which Sonar didn't pick up (basically because the changes hadn't been large enough!)
There was a problem hiding this comment.
these are some missing unit tests added in passing
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Some minor suggestions with regards to optimising the Dockerfiles we have been creating in the Lambdas directory.
|
* init * lint * smells * typo * imports * cleanup * sonarcloud * sonarcloud II * local Makefile * tests for get_s3_client * tests for get_s3_client II * delete .coverage * use_ms_precision * lint * shared helper functions * prefix * missing cache tests * test_errors * terraform fixes per VED-810 * review fixes * review fixes II * review fixes III
* init * lint * smells * typo * imports * cleanup * sonarcloud * sonarcloud II * local Makefile * tests for get_s3_client * tests for get_s3_client II * delete .coverage * use_ms_precision * lint * shared helper functions * prefix * missing cache tests * test_errors * terraform fixes per VED-810 * review fixes * review fixes II * review fixes III
3 participants
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.