VED-813-Fix NHS-Number-Change #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-813 |
JamesW1-NHS
requested changes
Sep 25, 2025
JamesW1-NHS
previously approved these changes
Sep 25, 2025
dlzhry2nhs
reviewed
Sep 25, 2025
| try: | ||
| patient_resource_parsed = json.loads(patient_resource) | ||
| except json.JSONDecodeError: | ||
| logger.warning("Failed to decode patient_resource JSON string") |
Contributor
There was a problem hiding this comment.
Should be error. Means we have somehow persisted bad data to our events DB.
dlzhry2nhs
reviewed
Sep 25, 2025
| logger.exception("process_nhs_number: failed to fetch demographic details: %s", e) | ||
| return make_status(str(e), nhs_number, "error") | ||
|
|
||
| logger.debug("Fetched PDS details: %s", pds_patient_resource) |
Contributor
There was a problem hiding this comment.
Are we permitted to log PID? If we enable debug logs, then this will come out.
dlzhry2nhs
previously approved these changes
Sep 25, 2025
Akol125
dismissed stale reviews from dlzhry2nhs and JamesW1-NHS
via
c4b261a
|
dlzhry2nhs
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.