VED-790-Redis-Schema-Storage #867
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-790 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # grafana/non-prod/docker/build_push_to_ecr.sh
nhsdevws
changed the title
| logger.info("No specific transformation defined for file type: %s", file_type) | ||
| return data # Default case, return data as is if no transformation is defined | ||
|
|
||
| return transform_generic(data, file_type) |
There was a problem hiding this comment.
Question: previously when no transformation was defined, transform_map() returned data; now it returns {}. Is this intentional?
There was a problem hiding this comment.
Previously it threw an exception. Unrecognized formats were not stored.
There was a problem hiding this comment.
Another question: why would we want to store unrecognised formats e.g. an arbitrary JSON file that the project does not need to retrieve from Redis?
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Several points require addressing. Some minor, but a major issue concerning how file naming and key naming so that we will not have to rework this when it comes to components retrieving the validation schema.
lambdas/redis_sync/src/constants.py
Outdated
| class RedisCacheKey: | ||
| PERMISSIONS_CONFIG_FILE_KEY = "permissions_config.json" | ||
| DISEASE_MAPPING_FILE_KEY = "disease_mapping.json" | ||
| VALIDATION_SCHEMA_FILE_KEY = "schema.json" |
There was a problem hiding this comment.
filename should be ValidationRules.JSON
dlzhry2nhs
left a comment
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Happy with the changes now - will approve once new file name is clarified.
|
3 participants
Summary
Permit upload to redis cache of json schema.
,
New version feathres:
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.