VED-759-Data Quality Reports

[Akol125]

Summary

• Routine Change
• ❗ Breaking Change
• 🤖 Operational or Infrastructure Change
• ✨ New Feature
• ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-795

[dlzhry2nhs]

You can regard my initial comment about setting up the lambda permissions as optional. Technically it is not required.

However, there are 2 things we need to address:

1. HTTPS only permission constraint
2. Clarify with architecture/tech lead on bucket per env config and implement accordingly

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dlzhry2nhs]

Seems to be an issue with Azure DevOps sending the success but all other steps passed.

Maybe give the pipeline a retry - but I am happy with the changes.