VED-872 Tighten given name validation#915
Merged
dlzhry2nhs merged 3 commits intomasterfrom Oct 20, 2025
Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-872 |
dlzhry2nhs
commented
Oct 17, 2025
| if len(field_value) == 0: | ||
| raise ValueError(f"{field_location} must be a non-empty array") | ||
|
|
||
| if max_length: |
Collaborator
Author
There was a problem hiding this comment.
This needs to be used carefully by us. Can add a docstring if you think useful, but when using this method you need to ensure you either use defined_length OR max_length. Though the code won't blow up, it does not really make sense to use both together, but nothing prevents you doing so.
dlzhry2nhs
commented
Oct 17, 2025
| ([], "contained[?(@.resourceType=='Patient')].name[0].given must be a non-empty array"), | ||
| ([""], "contained[?(@.resourceType=='Patient')].name[0].given[0] must be a non-empty string"), | ||
| ([" \n"], "contained[?(@.resourceType=='Patient')].name[0].given[0] must be a non-empty string"), | ||
| (["Test", " "], "contained[?(@.resourceType=='Patient')].name[0].given[1] must be a non-empty string"), |
Collaborator
Author
There was a problem hiding this comment.
Need to run past Krupa & Fatima. Have made a minor adjustment to the error message so that, when the error is to do with the element within the list, then we flag the index of the item with the problem.
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
JamesW1-NHS
approved these changes
Oct 20, 2025
dlzhry2nhs
had a problem deploying
to
internal-dev-sandbox
GitHub Actions
Failure
dlzhry2nhs
had a problem deploying
to
internal-dev
GitHub Actions
Error
|
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patient given name validation has been tightened up to align with PDS FHIR API validation. https://digital.nhs.uk/developer/api-catalogue/personal-demographics-service-fhir#post-/Patient
Namely:
By extension, the Practitioner given name also now is checked to ensure it is not a whitespace string. However, no further validation to do with the length is applied.
Check with testers: this change makes the given name validation error more specific by flagging which item in the array had an issue. Hopefully this is acceptable but needs checking and e2e tests may need updating accordingly.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.