VED-789: Gen Validation Schema#916
Merged
Akol125 merged 108 commits intostaging/VED-508-validation-refactor-and-dq-featurefrom Nov 11, 2025
Merged
VED-789: Gen Validation Schema#916Akol125 merged 108 commits intostaging/VED-508-validation-refactor-and-dq-featurefrom
Akol125 merged 108 commits intostaging/VED-508-validation-refactor-and-dq-featurefrom
Conversation
# Conflicts: # immunisation-fhir-api.code-workspace
dlzhry2nhs
reviewed
Nov 10, 2025
JamesW1-NHS
reviewed
Nov 10, 2025
lambdas/shared/src/common/validator/error_report/error_reporter.py
Outdated
Show resolved
Hide resolved
dlzhry2nhs
approved these changes
Nov 11, 2025
|
dlzhry2nhs
approved these changes
Nov 11, 2025
05db712
into
staging/VED-508-validation-refactor-and-dq-feature
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
This marks the beginning of a new generic validation engine that is fully configurable through a Redis-based schema. The schema defines the metadata and expression rules required for the engine to accurately parse and validate both Batch and API resources in a dynamic, extensible manner.
The validation process leverages these schemas to apply field-level and rule-based checks, ensuring flexibility without requiring code changes when validation logic evolves.
In addition, the engine features an extensive error classification system, categorising issues by severity and category. Validation results are generated in two distinct report formats, one of which is automatically exported to an S3 bucket, providing structured data for the Data Quality Team to analyse and monitor data integrity across ingestion workflows.
Read more using docs here - https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?pageId=914071143&spaceKey=Vacc&title=Immunisation%2BFHIR%2BAPI%2B-%2BGeneric%2BValidation%2BCSV%2BFHIR
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.