Skip to content

VED-804 Move record processor to Python Lambdas directory#935

Merged
dlzhry2nhs merged 8 commits intomasterfrom
feature/VED-804-move-record-processor-to-lambdas
Oct 28, 2025
Merged

VED-804 Move record processor to Python Lambdas directory#935
dlzhry2nhs merged 8 commits intomasterfrom
feature/VED-804-move-record-processor-to-lambdas

Conversation

@dlzhry2nhs
Copy link
Collaborator

@dlzhry2nhs dlzhry2nhs commented Oct 24, 2025

Summary

  • Routine Change

Key changes:

  • Standard moving of the directory and updating relevant locations e.g. terraform, makefiles, Dockerfile so that project still builds.
  • Shared functionality used: clients, logging helpers, errors.
  • Managed to remove some unused constants and duplicated Test Setup & Teardown methods.
  • Other than that, any code changes are broadly some of the Sonar warnings that got flagged as the code got moved.
  • Created a more detailed README for the recordprocessor.

Any more complex changes - e.g. consolidating audit table functions and constants between batch system lambdas - I have raised VED-881.

Reviews Required

  • Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-804

@dlzhry2nhs dlzhry2nhs marked this pull request as ready for review October 24, 2025 16:11
@sonarqubecloud
Copy link

@dlzhry2nhs dlzhry2nhs enabled auto-merge (squash) October 28, 2025 09:26
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox October 28, 2025 09:28 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs merged commit 6fc5e32 into master Oct 28, 2025
17 checks passed
@dlzhry2nhs dlzhry2nhs deleted the feature/VED-804-move-record-processor-to-lambdas branch October 28, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants