VED-850 Redundant code

[JamesW1-NHS]

Summary

• Routine Change

Small piece of code cleaning:

• models.failures.CsvImmunisationErrorModel doesn't appear to be used anywhere in the code at all. We can remove it.
• UpdateOutcome: the only value of this which is ever returned is UPDATE. We can remove it as well.

Note for testers: No functionality has changed here. Smoke testing only.

Reviews Required

• Dev
• Test
• Tech Author
• Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-850

[dlzhry2nhs]

We should not be looking for 'diagnostics' in patient. This is all legacy code from when we used to interact with PDS. I have removed it from the create journey and will be doing so for the in-flight ticket where we do the full refactoring of the update service.

[JamesW1-NHS]

Good spot. In fact that means I can remove the 'outcome' element from the method return entirely, and all the tests which check it.

[JamesW1-NHS]

After discussion, I won't remove the check for 'diagnostics' nor the 'outcome' element yet in this ticket. It should be resolved in 747.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud