VED-806 (Follow-up) Fix batch filter lambda bug#963
Merged
dlzhry2nhs merged 2 commits intomasterfrom Nov 3, 2025
Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-806 |
|
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev-sandbox
GitHub Actions
Inactive
dlzhry2nhs
temporarily deployed
to
internal-dev
GitHub Actions
Inactive
JamesW1-NHS
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/NHSDigital/immunisation-fhir-api/pull/952/files#diff-6f44ca2a77dbb72fb89ecddef26da185c716b653601a314f91b45af3a11acf4a Issue introduced by the refactoring and moving to the Lambdas directory.
Fairly trivial fix, the common
send_log_to_firehosefunction required an additional argument. The more worrying thing is that Python and our static checking does not seem to highlight this.All the tests use moto except the Firehose logging where we directly mock the method. This also helped to mask it.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.