VED-897 Remove PID from id sync lambda

[dlzhry2nhs]

Summary

• Routine Change

As per discussion in Slack this PR:

• Removes all PID from logs and internal responses.

I ended up making a non-trivial change:

• Removed the duplicate call we were making to PDS on every single journey. I can remove the relevant commit if we feel this is too high risk and should be broken out, but hopefully we can do some testing to validate it.

Additionally, there are some minor changes for:

• variable naming
• removed obsolete TF vars
• simplification of the code where appropriate (but nothing particularly deep given the scope of the ticket).
• update the PR template so there is a checkbox for PID. Not sure how effective this ultimately is.

Reviews Required

• Dev

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

• I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
• If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
• I have ensured the changelog has been updated by the submitter, if necessary.

[github-actions]

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-897

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud