Skip to content

Replace release script with GitHub Actions workflow #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianclay merged 2 commits into from
Jan 6, 2025
Merged

Replace release script with GitHub Actions workflow #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b8ba45
Replace release script with GitHub Actions workflow
adrianclay Jul 11, 2024
4431051
Suggestion from Ole
Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
on:
push:
tags: "*"

jobs:
push_to_dockerhub:
name: "Push Docker Images to DockerHub"
strategy:
Copy link
Contributor

@ORybak5 ORybak5 Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be a little bit clearer if we provide an additional description for the job like below:

jobs:
push_to_dockerhub:
name: "Push Docker Images to DockerHub"
strategy: ...

matrix:
image:
- {folder: service, dockerhub_name: nia-111-adaptor}
- {folder: nginx, dockerhub_name: nia-111-nginx-adaptor}
uses: NHSDigital/integration-adaptor-actions/.github/workflows/release-adaptor-container-image.yml@main
with:
dockerhub_name: ${{matrix.image.dockerhub_name}}
folder: ${{matrix.image.folder}}

secrets: inherit
23 changes: 0 additions & 23 deletions release-scripts/release.sh
View file
Open in desktop

This file was deleted.

Loading