NAID-3331: NHS best practices for GitHub Actions #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restrict permissions per job to ensure that only the least required permissions are granted in `build` workflow. * Use SHAs for GitHub Actions `actions` instead of versions to ensure we have control over exactly which version is being used in `build` workflow. * Change permissions for `Create Build ID Comment` to only allow `write` on pull requests.
MartinWheelerMT
force-pushed
the
niad-3331-nhs-best-practice-for-github-actions
branch
from
ad0d792 to
89d3bfd
Compare
|
Images built and published to ECR using a Build Id of PR-87-7e9cea4 |
chiaramapellimt
approved these changes
May 28, 2025
Alex-Nita
approved these changes
May 28, 2025
MartinWheelerMT
deleted the
niad-3331-nhs-best-practice-for-github-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildworkflow.actionsinstead of versions to ensure we have control over exactly which version is being used inbuildworkflow.Create Build ID Commentto only allowwriteon pull requests.