Skip to content

Commit fe5ea1e

Browse files
committed
small code refactoring
1 parent 5a72e5e commit fe5ea1e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

service/src/main/java/uk/nhs/adaptors/gp2gp/common/storage/StorageConnectorConfiguration.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
@Configuration
1717
@ConfigurationProperties(prefix = "gp2gp.storage")
1818
public class StorageConnectorConfiguration {
19+
20+
private static final Region REGION = Region.EU_WEST_2;
1921
private static final String S3_PREFIX = "s3";
2022

2123
private String type;
@@ -27,7 +29,7 @@ public class StorageConnectorConfiguration {
2729
@Bean
2830
public S3Client getS3Client() {
2931
if (StringUtils.isNotBlank(trustStoreUrl) && trustStoreUrl.startsWith(S3_PREFIX)) {
30-
return S3Client.builder().region(Region.EU_WEST_2).build();
32+
return S3Client.builder().region(REGION).build();
3133
}
3234

3335
return null;

service/src/test/java/uk/nhs/adaptors/gp2gp/common/configuration/CustomTrustStoreTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static void setUp() {
3737
.endpointOverride(URI.create("http://localhost:" + PORT))
3838
.credentialsProvider(StaticCredentialsProvider.create(
3939
AwsBasicCredentials.create("accessKey", "secretKey")))
40-
.region(Region.US_EAST_1)
40+
.region(Region.EU_WEST_2)
4141
.serviceConfiguration(S3Configuration.builder().pathStyleAccessEnabled(true).build())
4242
.build();
4343

0 commit comments

Comments
 (0)