NIAD-3216: When DiagnosticReport doesn't contain a Specimen reference, we are sending a value of DUMMY #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

MartinWheelerMT merged 14 commits into main from NIAD-3216-remove-dummy-from-specimen

Sep 25, 2025

Merged

NIAD-3216: When DiagnosticReport doesn't contain a Specimen reference, we are sending a value of DUMMY #1326

Merge branch 'main' into NIAD-3216-remove-dummy-from-specimen

GitHub Actions / pitest completed Sep 24, 2025 in 0s

Pitest mutation testing feedback

Surviving mutants in this change: 1
Killed mutants in this change: 16

class	surviving	killed
🧟`uk.nhs.adaptors.gp2gp.ehr.mapper.diagnosticreport.DiagnosticReportMapper`	1	16

See https://pitest.org

Annotations

Check warning on line 189 in service/src/main/java/uk/nhs/adaptors/gp2gp/ehr/mapper/diagnosticreport/DiagnosticReportMapper.java

github-actions / pitest

A change can be made to a lambda on line 189 without causing a test to fail

removed conditional - replaced equality check with true in 2nd lambda in assignDummySpecimensToObservationsWithNoSpecimen (covered by 5 tests RemoveConditionalMutator_EQUAL_IF)

View more details on GitHub Actions