Skip to content

NIAD-1456: started implementing new exception when EHR is unextractable as it does not contain clinical data#1363

Merged
chiaramapellimt merged 1 commit intomainfrom
NIAD-1456
Oct 16, 2025
Merged

NIAD-1456: started implementing new exception when EHR is unextractable as it does not contain clinical data#1363
chiaramapellimt merged 1 commit intomainfrom
NIAD-1456

Conversation

@chiaramapellimt
Copy link
Contributor

@chiaramapellimt chiaramapellimt commented Oct 7, 2025

What

GP2GP Adaptor now handles empty Access Structure Record.

Why

During a transfer from an NME to an incumbent, if there is no clinical data, then the adaptor should stop the transfer before it reaches the incumbent.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@chiaramapellimt chiaramapellimt force-pushed the NIAD-1456 branch 4 times, most recently from fac5517 to a5e7985 Compare October 13, 2025 14:39
@chiaramapellimt chiaramapellimt marked this pull request as ready for review October 13, 2025 15:36
@chiaramapellimt chiaramapellimt requested a review from a team as a code owner October 13, 2025 15:36
Jonopono123
Jonopono123 previously approved these changes Oct 15, 2025
@chiaramapellimt chiaramapellimt enabled auto-merge (squash) October 15, 2025 13:31
@chiaramapellimt chiaramapellimt changed the title NIAD-1456: started implementing new exception when ehr is unextractable WORKING VERSION - NIAD-1456: started implementing new exception when ehr is unextractable Oct 15, 2025
@chiaramapellimt chiaramapellimt force-pushed the NIAD-1456 branch 2 times, most recently from 47d709d to 7f3c87f Compare October 16, 2025 13:09
@chiaramapellimt chiaramapellimt changed the title WORKING VERSION - NIAD-1456: started implementing new exception when ehr is unextractable NIAD-1456: started implementing new exception when ehr is unextractable Oct 16, 2025
@chiaramapellimt chiaramapellimt changed the title NIAD-1456: started implementing new exception when ehr is unextractable NIAD-1456: started implementing new exception when EHR is unextractable as it does not contain clinical data Oct 16, 2025
@github-actions
Copy link

Looks good. All 2 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.ehr.mapper.EhrExtractMapper 0 2

See https://pitest.org

@sonarqubecloud
Copy link

@chiaramapellimt chiaramapellimt merged commit fb4bbde into main Oct 16, 2025
15 checks passed
@chiaramapellimt chiaramapellimt deleted the NIAD-1456 branch October 16, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants