Skip to content

Niad 1137/codeable concept cd mapper#1367

Merged
Jonopono123 merged 3 commits intomainfrom
NIAD-1137/CodeableConceptCdMapper
Oct 16, 2025
Merged

Niad 1137/codeable concept cd mapper#1367
Jonopono123 merged 3 commits intomainfrom
NIAD-1137/CodeableConceptCdMapper

Conversation

@Jonopono123
Copy link
Copy Markdown
Contributor

@Jonopono123 Jonopono123 commented Oct 15, 2025

What

  • Changed test condition to an exact match
  • Addressed disparity between expected and actual output xml in tests

Why

We want to phase out our usage of isEqualToIgnoringWhitespace() as it's allowing tests to pass that should be failing due to incorrect output.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@Jonopono123 Jonopono123 requested a review from a team as a code owner October 15, 2025 15:25
@github-actions
Copy link
Copy Markdown

Looks good. No mutations were possible for these changes.
See https://pitest.org

@sonarqubecloud
Copy link
Copy Markdown

@Jonopono123 Jonopono123 merged commit e444da4 into main Oct 16, 2025
15 checks passed
@Jonopono123 Jonopono123 deleted the NIAD-1137/CodeableConceptCdMapper branch October 16, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants