Skip to content

NIAD-3142: Refactor TransformJsonXmlTool #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiaramapellimt wants to merge 7 commits into
base: main
Choose a base branch
from

* Add highlight to console log output to make transform tool easier t…

2f3955c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

NIAD-3142: Refactor TransformJsonXmlTool #1384

* Add highlight to console log output to make transform tool easier t…
2f3955c
Select commit
Loading
Failed to load commit list.
GitHub Actions / pitest completed Oct 30, 2025 in 1s

Pitest mutation testing feedback

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 0
class surviving killed
🧟uk.nhs.adaptors.gp2gp.transformjsontoxmltool.TransformJsonToXml 4 0

See https://pitest.org

Annotations

Check warning on line 163 in service/src/main/java/uk/nhs/adaptors/gp2gp/transformjsontoxmltool/TransformJsonToXml.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 163 without causing a test to fail 

removed call to filter (no tests cover this line RemoveFilterMutator)

Check warning on line 162 in service/src/main/java/uk/nhs/adaptors/gp2gp/transformjsontoxmltool/TransformJsonToXml.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to line 162 without causing a test to fail 

replaced return value with null for getNhsNumberIdentifier (no tests cover this line NullReturnValsMutator)

Check warning on line 163 in service/src/main/java/uk/nhs/adaptors/gp2gp/transformjsontoxmltool/TransformJsonToXml.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to a lambda on line 163 without causing a test to fail 

replaced boolean return with false for 1st lambda in getNhsNumberIdentifier (no tests cover this line BooleanFalseReturnValsMutator)

Check warning on line 165 in service/src/main/java/uk/nhs/adaptors/gp2gp/transformjsontoxmltool/TransformJsonToXml.java

See this annotation in the file changed.

@github-actions github-actions / pitest

A change can be made to a lambda on line 165 without causing a test to fail 

replaced return value with null for 2nd lambda in getNhsNumberIdentifier (no tests cover this line NullReturnValsMutator)
View more details on GitHub Actions