NIAD-3192: Move from Jenkins to GitHub Actions #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial build action. * Add a unit test job in test.yml.
* Remove unneeded name parameter from `test.yml` * Remove unneeded quotation marks around named values
MartinWheelerMT
force-pushed
the
niad-3192-create-github-action-for-build
branch
from
3848839 to
6672990
Compare
MartinWheelerMT
force-pushed
the
niad-3192-create-github-action-for-build
branch
from
6672990 to
c085d74
Compare
…ocker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/mongo:3.2.4 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2`.
* Remove unnecessary passing of secrets to test workflow. * Remove unnecessary quotation marks around named valued.
* Add a job to `build.yml` to generate a build tag. * Add `create_build_id.sh` to create the build tag. * Add a job to `build.yml` to call publish workflow.
|
Images built and published to ECR using a Build Id of PR-20-5b640e7 |
MartinWheelerMT
commented
Apr 2, 2025
|
|
||
| public static final int MONGODB_PORT = 27017; | ||
| public static final String DEFAULT_IMAGE_AND_TAG = "mongo:3.2.4"; | ||
| public static final String DEFAULT_IMAGE_AND_TAG = "mongo:8.0"; |
Collaborator
Author
There was a problem hiding this comment.
This was updated due to TestContainers reporting the following issue due docker versioning on the GitHub runners:
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/mongo:3.2.4 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2`.
This change only affects the TestContainers startup stage for the integration tests.
ORybak5
reviewed
Apr 3, 2025
ORybak5
reviewed
Apr 3, 2025
ORybak5
reviewed
Apr 3, 2025
ORybak5
reviewed
Apr 3, 2025
ORybak5
reviewed
Apr 3, 2025
* Remove code checkout from the comment step. * Change permissions for the comment job to only have write access to pull-requests. * Remove duplicated command to remove stopped docker containers as already handled in the command above.
ORybak5
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.ymltest.ymlpublish.yml