Checkstyle fixes #302
Merged
Checkstyle fixes #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update gradle resources to version `8.0.0` * Breaking model changes now means that the `Parameter.getParameter(name)` now returns a `Type` which cannot now be cast to a `StringType`. We can work around this by finding the `ParametersParameterComponent` manually and then casting it to retrieve the value.
* Due to Parameter changes in the latest version, there is now a slightly different error phrasing in the error returned when a parameter is missing or empty. Integration tests have been updated to reflect this.
adjust modifiers to private
…declared as final).
… pattern `<Pattern>`.)
… of order with JLS suggestions.)
… is not followed by whitespace.)
…preceded with / followed by> whitespace.) * Address [IndentationLevel] checkstyle issues
…Name>` must match pattern '^([a-z][a-zA-Z0-9]*|_)$'.) * Address [MemberName] Checkstyle issues (Name `<LocalVariableName>` must match pattern '^([a-z][a-zA-Z0-9]*|_)$'.)
|
Images built and published to ECR using a Build Id of PR-81-03a04c7 |
Bhavesh-Patel
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pull request containing fixes to issues raised by CheckStyle.
These need to be resolved before we can add CheckStyle to the Github Actions pipeline.
This covers the following rule fixes:
It is easiest to review this PR on a commit by commit basis, as each issue is addressed in each commit.