Checkstyle Fixes #303
Merged
Checkstyle Fixes #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWheelerMT
force-pushed
the
checkstyle-fixes-2
branch
from
8153633 to
2bfd9f6
Compare
|
Images built and published to ECR using a Build Id of PR-89-8c287d9 |
…be declared as final.)
…Name>' must be private and have accessor methods.)
…orrect indentation level *, expected level should *.)
… found.) * Remove now unneeded test config class * Change test classes using parameter construction to use the configuration properties class instead and set the values * Update mesh config to use configuration properties
* Changed TimeStamp creation in tests to parse ISO date string as this is recognized by CheckStyle as a valid format not magic numbers. * Add `EdifactAddressPart` enumerated class as these indices are required across multiple person classes.
…d have been `2020-06-10T14:38:00` when converting from `ZonedDateTime.of(2020, 6, 10, 14, 38, 00, 0, TimestampService.UK_ZONE)`
MartinWheelerMT
force-pushed
the
checkstyle-fixes-2
branch
from
634e6f6 to
189d7cd
Compare
Alex-Nita
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second pull request containing fixes to issues raised by CheckStyle.
These need to be resolved before we can add CheckStyle to the Github Actions pipeline.
This covers the following rule fixes:
This introduces the following changes:
EdifactAddressPartenumerated class as these indices are required across multiple person classes.It is easiest to review this PR on a commit by commit basis, as each issue is addressed in each commit.