PPHA-475: Remove /start path submission in favour of link

Author: Themitchell

lung_cancer_screening/questions/jinja2/start.jinja

@@ -1,35 +1,17 @@
 {% extends 'layout.jinja' %}
-{% from 'nhsuk/components/error-summary/macro.jinja' import errorSummary %}
 {% from 'nhsuk/components/button/macro.jinja' import button %}
-{% from 'nhsuk/components/input/macro.jinja' import input %}
 
 {% block content %}
-
-  {% if error_messages %}
-    {{ errorSummary({
-      "titleText": "There is a problem",
-      "errorList": error_messages
-    }) }}
-  {% endif %}
-
   <div class="nhsuk-grid-row">
     <div class="nhsuk-grid-column-two-thirds">
-      <form action="{{ request.path }}" method="POST">
-        {{ csrf_input }}
-
-        {{ input({
-          "label": {
-            "text": "Enter your unique user ID",
-            "isPageHeading": true
-          },
-          "id": "user_id",
-          "name": "user_id"
-        }) }}
+      <h1 class="nhsuk-heading-l">
+        Lung Cancer Risk Check
+      </h1>
 
-        {{ button({
-            "text": "Start now"
-        }) }}
-      </form>
+      {{ button({
+        "text": "Start now",
+        "href": url("questions:have_you_ever_smoked")
+      }) }}
     </div>
   </div>
 {% endblock %}

lung_cancer_screening/questions/tests/unit/views/test_start.py

@@ -12,78 +12,3 @@ def test_get_responds_successfully(self):
         response = self.client.get(reverse("questions:start"))
 
         self.assertEqual(response.status_code, 200)
-
-class TestPostStart(TestCase):
-    def setUp(self):
-        login_user(self.client)
-
-    def test_post_redirects_if_the_user_is_not_logged_in(self):
-        self.client.logout()
-
-        response = self.client.post(
-            reverse("questions:start"),
-            {"user_id": "12345"}
-        )
-
-        self.assertRedirects(response, "/oidc/authenticate/?next=/start", fetch_redirect_response=False)
-
-    # TODO: Remove response set creation and make endpoints create it themselves if it does not exist
-
-    # def test_post_creates_a_new_user_and_response_set(self):
-    #     self.client.post(
-    #         reverse("questions:start"),
-    #         {"user_id": "12345"}
-    #     )
-
-    #     user = Participant.objects.all().last()
-    #     self.assertEqual(user.unique_id, "12345")
-    #     self.assertEqual(user.responseset_set.count(), 1)
-
-    # def test_post_creates_a_new_response_set_if_the_user_already_exists_and_has_no_response_set_submitted_in_the_last_year(self):
-    #     user = UserFactory()
-    #     old_response_set = user.responseset_set.create(
-    #         submitted_at=timezone.now() - relativedelta(days=365)
-    #     )
-
-    #     self.client.post(
-    #         reverse("questions:start"),
-    #         {"user_id": user.unique_id}
-    #     )
-
-    #     self.assertEqual(user.responseset_set.count(), 2)
-    #     self.assertNotEqual(user.responseset_set.last().id, old_response_set.id)
-
-    # def test_post_shows_an_error_if_a_response_set_was_submitted_within_the_last_year(self):
-    #     user = UserFactory()
-    #     user.responseset_set.create(
-    #         submitted_at=timezone.now() - relativedelta(days=364)
-    #     )
-
-    #     response = self.client.post(
-    #         reverse("questions:start"),
-    #         {"user_id": user.unique_id}
-    #     )
-
-    #     self.assertEqual(response.status_code, 422)
-    #     self.assertIn(
-    #         "Responses have already been submitted for this user",
-    #         response.text
-    #     )
-
-
-    # def test_post_redirects_to_the_have_you_ever_smoked_path(self):
-    #     response = self.client.post(
-    #         reverse("questions:start"),
-    #         {"user_id": "12345"}
-    #     )
-
-    #     self.assertRedirects(response, reverse("questions:have_you_ever_smoked"))
-
-    # def test_post_responds_with_422_if_the_user_fails_to_create(self):
-    #     response = self.client.post(
-    #         reverse("questions:start"),
-    #         {"user_id": ""}
-    #     )
-
-    #     self.assertEqual(response.status_code, 422)
-

lung_cancer_screening/questions/views/start.py

@@ -1,28 +1,9 @@
-from django.shortcuts import render, redirect
-from django.urls import reverse
-from django.core.exceptions import ValidationError
-from django.contrib.auth.decorators import login_required
-from django.utils.decorators import method_decorator
+from django.shortcuts import render
 from django.views import View
 
-
-@method_decorator(login_required, name='post')
 class StartView(View):
     def get(self, request):
         return render(
             request,
             "start.jinja"
         )
-
-    def post(self, request):
-        try:
-            request.user.responseset_set.create()
-
-            return redirect(reverse("questions:have_you_ever_smoked"))
-        except ValidationError as e:
-            return render(
-                request,
-                "start.jinja",
-                {"error_messages": [{ "text": message } for message in e.messages ]},
-                status=422
-            )

tests/features/cannot_change_answers_after_submission.feature

@@ -5,4 +5,3 @@ Feature: Participants with submitted responses
     When I go to "/start"
     And I click "Start"
     Then I am on "/start"
-    And I see an error summary "Responses have already been submitted for this user"