-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/config update #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/config update #112
Conversation
README.md
Outdated
| make dev-run | ||
| ``` | ||
|
|
||
| After starting the application, apply the database migrations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because migrations run through docker compose running make dev-migrate will bring up the postgres container and run the migrations from the web container which means you don't need to start the application first. The docker compose file just habdles the stack for you so theres no interdependency there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I will make this edit.
Themitchell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good bar the small comment re starting the app before running migrations
0e0ee49 to
c0af330
Compare
Description
This PR fixes Makefile syntax errors that were preventing proper execution with
.ONESHELLmode, updates the Python version to match the Dockerfile, and improves the README with comprehensive setup instructions.Changes include:
_install-dependenciesand_testtargets with proper line continuations and semicolons.tool-versionsto use Python 3.13.7 (matching Dockerfile).env.examplecopy step and database migration requirementContext
The Makefile targets were failing with "syntax error: unexpected end of file" because the bash commands weren't properly formatted for Make's
.ONESHELLmode. This blocked developers from runningmake configandmake testsuccessfully.Additionally, the README was missing critical setup steps that new developers would need, including:
.env.exampleto.envType of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable
Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain
any sensitive information. We really appreciate your cooperation in this matter.