Use generic valid date error for dob upper and lower bound validations #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Themitchell
changed the title
Themitchell
changed the title
jamiefalcus
previously approved these changes
Nov 24, 2025
Themitchell
force-pushed
the
handle-incorrect-day-month-year-validation-error-for-dob
branch
from
926aa84 to
1379afe
Compare
Themitchell
force-pushed
the
handle-incorrect-day-month-year-validation-error-for-dob
branch
from
1379afe to
33d77a8
Compare
|
jamiefalcus
approved these changes
Nov 24, 2025
Themitchell
deleted the
handle-incorrect-day-month-year-validation-error-for-dob
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
When validating dob use a more generic "Date of birth must be a valid date" error instead of specifying dates and months being between a specific value
Why are we making this change?
Validation errors for specific date / month ranges can be confusing given the variable days in each month. Instead a more generic validation error for "Must be a valid date" makes more sense to the end user and aligns with other NHS services using this pattern