Skip to content

Conversation

@tvararu
Copy link
Member

@tvararu tvararu commented Sep 5, 2025

This is a typechecking tool that provides some basic safeguards against calling python functions with incorrect argument lists, even if you don't opt into the optional type annotations.

It's mostly nice to have if your editor supports the LSP it provides.

Also reorganise imports according to more modern standards, and don't install dev deps in the Docker container (oops!)

This is more modern and `uv add --dev` defaults to it.
We don't need these when running the app in production mode.
This is a typechecking tool that provides some basic safeguards against
calling python functions with incorrect argument lists, even if you
don't opt into the optional type annotations.

It's mostly nice to have if your editor supports the LSP it provides.
The github one looks better in CI.
Add missing type annotations to functions that require them.
@tvararu tvararu requested a review from a team as a code owner September 5, 2025 12:17
@tvararu
Copy link
Member Author

tvararu commented Sep 5, 2025

CI is failing because of a 404 on the download link for mise.

mise ci passes locally:

$ mise ci
[uv:sync] $ uv sync --group dev
[gitleaks] $ gitleaks detect --verbose --redact
[uv:sync] Resolved 37 packages in 0.48ms
[uv:sync]    Building manage-vaccinations-in-schools-reporting @ file:///Users/deity/Code/mavis-reporting
[gitleaks]
[gitleaks]     ○
[gitleaks]     │╲
[gitleaks]     │ ○
[gitleaks]     ○ ░
[gitleaks]     ░    gitleaks
[gitleaks]
[uv:sync]       Built manage-vaccinations-in-schools-reporting @ file:///Users/deity/Code/mavis-reporting
[uv:sync] Prepared 1 package in 167ms
[uv:sync] Uninstalled 1 package in 0.63ms
[uv:sync] Installed 1 package in 1ms
[uv:sync]  ~ manage-vaccinations-in-schools-reporting==0.1.0 (from file:///Users/deity/Code/mavis-reporting)
[uv:sync] Finished in 185.6ms
[typecheck] $ uv run pyright
[test] $ uv run pytest tests
[lint] $ uv run ruff check .
[lint] Finished in 29.7ms
[gitleaks] 7:23PM INF 187 commits scanned.
[gitleaks] 7:23PM INF scanned ~945049 bytes (945.05 KB) in 153ms
[gitleaks] 7:23PM INF no leaks found
[gitleaks] Finished in 318.2ms
[test] ============================= test session starts ==============================
[test] platform darwin -- Python 3.13.2, pytest-8.4.1, pluggy-1.6.0
[test] rootdir: /Users/deity/Code/mavis-reporting
[test] configfile: pyproject.toml
[test] collected 22 items
[test]
[test] tests/auth/test_auth.py ....                                             [ 18%]
[test] tests/helpers/test_auth_helper.py ....                                   [ 36%]
[test] tests/helpers/test_mavis_helper.py ........                              [ 72%]
[test] tests/helpers/test_url_helper.py ......                                  [100%]
[test]
[test] ============================== 22 passed in 0.13s ==============================
[test] Finished in 318.6ms
[typecheck] 0 errors, 0 warnings, 0 informations
[typecheck] Finished in 1.04s
Finished in 1.22s

@tvararu tvararu merged commit 4fd6ebc into main Sep 5, 2025
2 of 8 checks passed
@tvararu tvararu deleted the pyright branch September 5, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants