Skip to content

Conversation

@simonnorris1
Copy link
Contributor

Description

Update to E2E performance test workflow

Context

This PR includes:

  • Changes to the nurse journey JMeter script to work with a file
  • Changes to the consent journey JMeter script to work with a file
  • Changes to the upload file JMeter script to form the second step of the E2E process (the first step will be automated authoring/retrieval of a cohort file)

Workflow changes:

  • Run the scripts in sequence and generate individual reports.
  • Give the option of enabling/disabling the data prep stages (in case the data has been prepared beforehand)
  • Give the option of enabling/disabling the nurse journey in order to prep data independently
  • Update the run settings of consent journey in order to cope with any size file

Other changes:

  • Far too many bug fixes and typos

Next steps:

  • Create process to author/retrieve cohort files
  • Send test results to splunk (possible)
  • Figure out why part of the JMeter scripts are being reported as holding secrets (build error)

Type of changes

  • [x ] Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • [x ] Breaking change (fix or feature that would change existing functionality)
  • [x ] Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • [x ] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Reduce upload artifact from error to warn, to allow the valid outcome of 'no files found'
Running old script, corrected
The workflow now includes options to turn off either the data prep and/or nurse journey steps. This is so the two stages can be run separately. By default both steps are selected.
Temporary cohort file to test upload and consent journey
Add upload-cohort-data.jmx stage
Debugging, limit consent test to ten minutes so the test can finish and output results
Debugging consent journey, limiting executions to 50
A current issue with JMeter is the misreporting of conflicting cookie managers. This addition changes the log level to debug so the messages don't swamp the output log. This will reduce the log size of all JMeter reports.
The test is designed to expire once it reaches the end of a file, therefore the number of threads and loops only need to exceed any likely scenario. For now it's set to 20 threads and 1000 loops, giving an import file of 20000 records. This is impossible at the moment due to an app limit of <15000.
Removed a default file reference that was referring to a deleted file
Fixed a change made in consent-journey and repeated here
@simonnorris1 simonnorris1 merged commit 0b67fdc into main May 19, 2025
21 of 23 checks passed
@simonnorris1 simonnorris1 deleted the perf_test_bugfixes branch May 19, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant