generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Perf test bugfixes #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Perf test bugfixes #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing backslash
Reduce upload artifact from error to warn, to allow the valid outcome of 'no files found'
Running old script, corrected
The workflow now includes options to turn off either the data prep and/or nurse journey steps. This is so the two stages can be run separately. By default both steps are selected.
Temporary cohort file to test upload and consent journey
Add upload-cohort-data.jmx stage
Debugging, limit consent test to ten minutes so the test can finish and output results
Debugging consent journey, limiting executions to 50
A current issue with JMeter is the misreporting of conflicting cookie managers. This addition changes the log level to debug so the messages don't swamp the output log. This will reduce the log size of all JMeter reports.
The test is designed to expire once it reaches the end of a file, therefore the number of threads and loops only need to exceed any likely scenario. For now it's set to 20 threads and 1000 loops, giving an import file of 20000 records. This is impossible at the moment due to an app limit of <15000.
Removed a default file reference that was referring to a deleted file
Fixed a change made in consent-journey and repeated here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to E2E performance test workflow
Context
This PR includes:
Workflow changes:
Other changes:
Next steps:
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.