Skip to content

Make providing a basic auth username/password or token optional #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jf-x-dev merged 1 commit into from
Nov 21, 2025
Merged

Make providing a basic auth username/password or token optional #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.generic
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
PROGRAMMES_ENABLED=FLU,HPV,MENACWY,MMR,TD_IPV
BASE_URL=https://qa.mavistesting.com

# if running tests against an environment behind basic auth (e.g. qa)
# provide either a token or a username/password pair
BASIC_AUTH_USERNAME=
BASIC_AUTH_PASSWORD=
Expand Down
4 changes: 3 additions & 1 deletion mavis/test/fixtures/playwright.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,7 @@ def browser_context_args(
**browser_context_args,
"extra_http_headers": {"Authorization": f"Basic {basic_auth_token}"},
}
if basic_auth_credentials["username"] and basic_auth_credentials["password"]:
return {**browser_context_args, "http_credentials": basic_auth_credentials}

return {**browser_context_args, "http_credentials": basic_auth_credentials}
return browser_context_args