Remove all page fixtures #803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how page objects are used in tests.
Currently we have a fixture for every individual page object, and in each test these fixtures are passed as arguments. This is how we use the functionality of each of these page objects.
There are some problems with this approach though:
A simpler approach is to just pass the Playwright
pagefixture to tests, and then create the necessary page objects in the test (e.g. callingLogInPage(page).log_in()). This allows us to: