Add test reports to S3 bucket instead of github pages #902
Conversation
jf-x-dev
force-pushed
the
add-reports-to-bucket
branch
from
3d50fde to
41818ce
Compare
| default: 'endtoendtest-reports' | ||
| report-base-url: | ||
| required: true | ||
| default: 'https://d2h72ta68jwsgq.cloudfront.net' |
There was a problem hiding this comment.
I'm wondering if we could have a more user friendly domain name here?
There was a problem hiding this comment.
We could! I wasn't convinced it was worth it as I'm still not really sure how often these will be used.
Something like www.reports.mavistesting.com would work. It breaks our pattern of using subdomains for environments but I don't think we'll set up a reports environment anytime soon.
(Otherwise mavisreports.com is available, though the $15 / year cost is probably more than the storage costs 😅)
Do you have any thoughts/suggestions?
There was a problem hiding this comment.
Yeah I don't think we need to pay for a domain name for these, but I guess I hoping for a name that seems more stable. Maybe this one won't change, but I can just imagine if it does we wouldn't want all the existing links to break.
I don't love using the mavistesting.com domain, but we could if we had to.
There was a problem hiding this comment.
As far as I know, this name is stable and will only change if we intentionally edit it.
I would lean towards keeping https://d2h72ta68jwsgq.cloudfront.net for now. If users find it confusing then we could add something like reports.mavistesting.com as an alias which would make new links nicer but keep all preexisting links working
2 participants
Updates the
deploy-reportscomposite action to now upload reports to an S3 bucket instead of github pages, and then link the corresponding Cloudfront url.Corresponding mavis PR: nhsuk/manage-vaccinations-in-schools#5891