Improve performance

Include vaccination records, and associated programmes in the high level patient query. This means that there no longer needs to be a database request for every patient when loading the Important notices page, because `PatientsHelper.patient_important_notices` can now work on all the patients entirely in memory

Author: alistair-white-horne-tng

app/controllers/imports/notices_controller.rb

@@ -6,10 +6,19 @@ class Imports::NoticesController < ApplicationController
   def index
     authorize :notices
 
-    @deceased_patients = policy_scope(Patient).deceased
-    @invalidated_patients = policy_scope(Patient).invalidated
-    @restricted_patients = policy_scope(Patient).restricted
+    @deceased_patients =
+      policy_scope(Patient).deceased.includes(vaccination_records: :programme)
+    @invalidated_patients =
+      policy_scope(Patient).invalidated.includes(
+        vaccination_records: :programme
+      )
+    @restricted_patients =
+      policy_scope(Patient).restricted.includes(vaccination_records: :programme)
     @has_vaccination_records_dont_notify_parents_patients =
-      policy_scope(Patient).has_vaccination_records_dont_notify_parents
+      policy_scope(
+        Patient
+      ).has_vaccination_records_dont_notify_parents.includes(
+        vaccination_records: :programme
+      )
   end
 end

spec/helpers/patients_helper_spec.rb

@@ -123,9 +123,14 @@
   end
 
   describe "patient_important_notices" do
-    subject(:notifications) { helper.patient_important_notices(patient) }
+    subject(:notifications) do
+      helper.patient_important_notices(patient_with_preloaded_associations)
+    end
 
     let(:patient) { create(:patient) }
+    let(:patient_with_preloaded_associations) do
+      Patient.includes(vaccination_records: :programme).find(patient.id)
+    end
     let(:programme) { create(:programme, :hpv) }
 
     context "when patient has no special status" do