-
Notifications
You must be signed in to change notification settings - Fork 1
[PRM-591] Workflow concurrency to prevent overlapping workspace executions #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwhitingnhs
previously approved these changes
Oct 28, 2025
|
Report for environment: ndr-devTerraform Initialization ⚙️
|
jameslinnell
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Problem
Each time a branch is merged to
main, or a commit is added to a branch which has an open PR, theZ-AUTOMATED: Deploy - Devworkflow is initiated against thendr-devworkspace - this process locks the terraform state during execution.When multiple triggering events occur in quick succession, a state lock problem occurs because the workflow runs overlap - this results in a failure and simply rerunning the job will 'fix' the issue (as long as it's not rerun at the same time as another job touching the same workspace).
This could happen to any workspace/sandbox, but is most likely to affect
ndr-dev.The Fix
GitHub workflows offer a
concurrencyflag, to prevent workflows within a repository running simultaneously. Setting the concurrencygroupto the workspace/sandbox name will prevent the state being used when locked.Testing
To test this, kick off the following workflows in order using the same sandbox name (remember to use this branch's workflow):