Skip to content

[PRMP-975] Document Search Results Backend - Pagination #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steph-torres-nhs wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[PRMP-975] Document Search Results Backend - Pagination #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34f98ea
[PRMP-975] format
steph-torres-nhs Jan 14, 2026
9e310b6
[PRMP-975] add env var
steph-torres-nhs Jan 14, 2026
24c8b1d
[PRMP-975] test adding sort key to gsi
steph-torres-nhs Jan 16, 2026
f48e78d
Merge branch 'main' into PRMP-975
steph-torres-nhs Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions infrastructure/dynamo_db.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ module "lloyd_george_reference_dynamodb_table" {
{
name = "S3FileKey"
type = "S"
},
{
name = "Created"
type = "S"
}
]

Expand All @@ -105,6 +109,7 @@ module "lloyd_george_reference_dynamodb_table" {
{
name = "NhsNumberIndex"
hash_key = "NhsNumber"
range_key = "Created"
projection_type = "ALL"
},
{
Expand Down
10 changes: 5 additions & 5 deletions infrastructure/lambda-search-doc-references.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ module "search-document-references-lambda" {
http_methods = ["GET"]
api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn
lambda_environment_variables = {
APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id
APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id
APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id
DYNAMODB_TABLE_LIST = "[\u0022${terraform.workspace}_${var.docstore_dynamodb_table_name}\u0022, \u0022${terraform.workspace}_${var.lloyd_george_dynamodb_table_name}\u0022]"
WORKSPACE = terraform.workspace
APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id
APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id
APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id
LLOYD_GEORGE_DYNAMODB_NAME = module.lloyd_george_reference_dynamodb_table.table_name
WORKSPACE = terraform.workspace
}
depends_on = [
aws_api_gateway_rest_api.ndr_doc_store_api,
Expand Down
1 change: 1 addition & 0 deletions infrastructure/lambda-search-document-references-fhir.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module "search-document-references-fhir-lambda" {
DYNAMODB_TABLE_LIST = "[\u0022${module.core_dynamodb_table.table_name}\u0022, \u0022${module.lloyd_george_reference_dynamodb_table.table_name}\u0022]"
DOCUMENT_RETRIEVE_ENDPOINT_APIM = "${local.apim_api_url}/DocumentReference"
WORKSPACE = terraform.workspace
LLOYD_GEORGE_DYNAMODB_NAME = module.lloyd_george_reference_dynamodb_table.table_name
Copy link
Contributor

@NogaNHS NogaNHS Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to remove DYNAMODB_TABLE_LIST here too?

}
depends_on = [
aws_api_gateway_rest_api.ndr_doc_store_api,
Expand Down