[PRM-92] Anywhere we use target="_blank" in the code has outer parentheses rem… (#608)

* Anywhere we use target="_blank" in the code has outer parentheses removed

* [PRM-92] fix broken ui unit tests

---------

Co-authored-by: Steph Torres <[email protected]>

Author: oliverbeumkes-nhs

app/src/components/blocks/_arf/documentInputForm/DocumentInputForm.tsx

@@ -69,7 +69,7 @@ const DocumentInputForm = ({
                                     href="https://secure.pcse.england.nhs.uk/"
                                     target="_blank"
                                     rel="noreferrer"
-                                    aria-label="(Primary Care Support England - this link will open in a new tab)"
+                                    aria-label="Primary Care Support England - this link will open in a new tab"
                                 >
                                     Primary Care Support England
                                 </a>

app/src/components/blocks/_arf/selectStage/SelectStage.test.tsx

@@ -157,7 +157,7 @@ describe('<SelectStage />', () => {
         it('renders link to PCSE that opens in a new tab', () => {
             renderApp();
             const pcseLink = screen.getByRole('link', {
-                name: '(Primary Care Support England - this link will open in a new tab)',
+                name: 'Primary Care Support England - this link will open in a new tab',
             });
             expect(pcseLink).toHaveAttribute('href', 'https://secure.pcse.england.nhs.uk/');
             expect(pcseLink).toHaveAttribute('target', '_blank');

app/src/components/blocks/_delete/deleteResultStage/DeleteResultStage.tsx

@@ -69,6 +69,7 @@ function DeleteResultStage({ numberOfFiles, setDownloadStage }: Props) {
                     href="https://transform.england.nhs.uk/information-governance/guidance/records-management-code"
                     target="_blank"
                     rel="noreferrer"
+                    aria-label="Record Management Code of Practice - this link will open in a new tab"
                 >
                     Record Management Code of Practice
                 </a>{' '}

app/src/components/blocks/_lloydGeorge/lloydGeorgeRetryUploadStage/LloydGeorgeRetryUploadStage.test.tsx

@@ -28,7 +28,7 @@ describe('LloydGeorgeRetryUploadStage', () => {
             });
             expect(
                 screen.getByRole('link', {
-                    name: '(NHS National Service Desk - this link will open in a new tab)',
+                    name: 'NHS National Service Desk - this link will open in a new tab',
                 }),
             ).toHaveAttribute(
                 'href',

app/src/components/blocks/_lloydGeorge/lloydGeorgeUploadFailedStage/LloydGeorgeUploadFailedStage.test.tsx

@@ -29,7 +29,7 @@ describe('LloydGeorgeUploadFailedStage', () => {
             });
             expect(
                 screen.getByRole('link', {
-                    name: '(NHS National Service Desk - this link will open in a new tab)',
+                    name: 'NHS National Service Desk - this link will open in a new tab',
                 }),
             ).toHaveAttribute(
                 'href',

app/src/components/blocks/_lloydGeorge/lloydGeorgeUploadInfectedStage/LloydGeorgeUploadInfectedStage.test.tsx

@@ -51,7 +51,7 @@ describe('LloydGeorgeUploadInfectedStage', () => {
 
             expect(
                 screen.getByRole('link', {
-                    name: '(NHS National Service Desk - this link will open in a new tab)',
+                    name: 'NHS National Service Desk - this link will open in a new tab',
                 }),
             ).toHaveAttribute(
                 'href',

app/src/components/generic/serviceDeskLink/ServiceDeskLink.tsx

@@ -6,7 +6,7 @@ const ServiceDeskLink = () => {
             href="https://digital.nhs.uk/about-nhs-digital/contact-us#nhs-digital-service-desks"
             target="_blank"
             rel="noreferrer"
-            aria-label="(NHS National Service Desk - this link will open in a new tab)"
+            aria-label="NHS National Service Desk - this link will open in a new tab"
         >
             NHS National Service Desk
         </a>

app/src/components/layout/phaseBanner/PhaseBanner.test.tsx

@@ -31,7 +31,7 @@ describe('PhaseBanner', () => {
         it('renders a link to the feedback form page if user is logged in', () => {
             renderComponent({ isLoggedIn: true });
             const feedbackLink = screen.getByRole('link', {
-                name: '(feedback - this link will open in a new tab)',
+                name: 'feedback - this link will open in a new tab',
             });
 
             expect(feedbackLink).toHaveAttribute('href', routes.FEEDBACK);

app/src/components/layout/phaseBanner/PhaseBanner.tsx

@@ -11,7 +11,7 @@ function PhaseBanner() {
             to={routes.FEEDBACK}
             target="_blank"
             rel="opener"
-            aria-label="(feedback - this link will open in a new tab)"
+            aria-label="feedback - this link will open in a new tab"
         >
             feedback
         </Link>

app/src/components/layout/serviceErrorBox/ServiceErrorBox.test.tsx

@@ -23,7 +23,7 @@ describe('ServiceError', () => {
         ).toBeInTheDocument();
         expect(
             screen.getByRole('link', {
-                name: '(NHS National Service Desk - this link will open in a new tab)',
+                name: 'NHS National Service Desk - this link will open in a new tab',
             }),
         ).toBeInTheDocument();
     });
@@ -32,7 +32,7 @@ describe('ServiceError', () => {
         render(<ServiceError />);
 
         const serviceDeskLink = screen.getByRole('link', {
-            name: '(NHS National Service Desk - this link will open in a new tab)',
+            name: 'NHS National Service Desk - this link will open in a new tab',
         });
         expect(serviceDeskLink).toHaveAttribute(
             'href',