[PRMP-1074] Refreshing browser redirects to search patient page (#476)

* [PRMP-1074] Refreshing browser redirects to search patient page

* [PRMP-1074] Cypress test for browser refresh

* [PRMP-1074] Removed unused import

* [PRMP-1074] - Return to patient search if nhsNumber missing

* [PRMP-1074] - Return to patient search if nhsNumber missing when downloading files

---------

Co-authored-by: Mohammad Iqbal <mohammad.iqbal27@nhs.net>
Co-authored-by: oliverbeumkes-nhs <oliver.beumkes2@nhs.net>

Author: 3 people

app/cypress/e2e/0-ndr-core-tests/auth_routes/auth_general_browser_states.cy.js

@@ -1,5 +1,7 @@
 import authPayload from '../../../fixtures/requests/auth/GET_TokenRequest_GP_ADMIN.json';
 import { Roles } from '../../../support/roles';
+import dbItem from '../../../fixtures/dynamo-db-items/active-patient.json';
+import searchPatientPayload from '../../../fixtures/requests/GET_SearchPatientLGUpload.json';
 
 describe('Authentication & Authorisation', () => {
     const baseUrl = Cypress.config('baseUrl');
@@ -86,4 +88,42 @@ describe('Authentication & Authorisation', () => {
             },
         );
     });
+
+    context('Page refresh redirection ', () => {
+        const workspace = Cypress.env('WORKSPACE');
+        dbItem.FileLocation = dbItem.FileLocation.replace('{env}', workspace);
+
+        const lloydGeorgeRecordUrl = '/patient/lloyd-george-record';
+        const verifyUrl = '/patient/verify';
+        const patientSearchUrl = '/patient/search';
+
+        it(
+            'Refreshing the browser after searching for a patient will return the user to the patient search page',
+            { tags: 'regression ', defaultCommandTimeout: 20000 },
+            () => {
+                cy.login(Roles.GP_ADMIN);
+                cy.visit(patientSearchUrl);
+
+                cy.intercept('GET', '/SearchPatient*', {
+                    statusCode: 200,
+                    body: searchPatientPayload,
+                }).as('search');
+                cy.intercept('POST', '/LloydGeorgeStitch*', {
+                    statusCode: 404,
+                }).as('stitch');
+
+                cy.getByTestId('nhs-number-input').type(searchPatientPayload.nhsNumber);
+                cy.getByTestId('search-submit-btn').click();
+
+                cy.url().should('contain', verifyUrl);
+                cy.get('#verify-submit').click();
+
+                cy.url().should('contain', lloydGeorgeRecordUrl);
+
+                cy.reload();
+
+                cy.url().should('contain', patientSearchUrl);
+            },
+        );
+    });
 });

app/src/components/blocks/_lloydGeorge/lloydGeorgeDownloadStage/LloydGeorgeDownloadStage.tsx

@@ -95,6 +95,10 @@ function LloydGeorgeDownloadStage({
         const onPageLoad = async () => {
             progressTimer.stop();
             window.clearInterval(intervalTimer);
+            if (!nhsNumber) {
+                navigate(routes.SEARCH_PATIENT);
+                return;
+            }
             try {
                 const preSignedUrl = await getPresignedUrlForZip({
                     baseUrl,

app/src/components/blocks/_lloydGeorge/lloydGeorgeSelectDownloadStage/LloydGeorgeSelectDownloadStage.tsx

@@ -85,6 +85,10 @@ function LloydGeorgeSelectDownloadStage({
     useEffect(() => {
         const onPageLoad = async () => {
             setSubmissionSearchState(SEARCH_AND_DOWNLOAD_STATE.SEARCH_PENDING);
+            if (!nhsNumber) {
+                navigate(routes.SEARCH_PATIENT);
+                return;
+            }
             try {
                 // This check is in place for when we navigate directly to a full download,
                 // in that instance we do not need to get a list of selectable files as we will download all files

app/src/router/guards/patientGuard/PatientGuard.test.tsx

@@ -19,13 +19,13 @@ describe('AuthGuard', () => {
     afterEach(() => {
         jest.clearAllMocks();
     });
-    it('navigates user to unauthorised when no patient is searched', async () => {
+    it('navigates user to search patient page when no patient details are stored', async () => {
         mockedUsePatient.mockReturnValue(null);
 
         renderGuard();
 
         await waitFor(async () => {
-            expect(mockedUseNavigate).toHaveBeenCalledWith(routes.UNAUTHORISED);
+            expect(mockedUseNavigate).toHaveBeenCalledWith(routes.SEARCH_PATIENT);
         });
     });
 

app/src/router/guards/patientGuard/PatientGuard.tsx

@@ -12,7 +12,7 @@ function PatientGuard({ children }: Props) {
     const navigate = useNavigate();
     useEffect(() => {
         if (!patient) {
-            navigate(routes.UNAUTHORISED);
+            navigate(routes.SEARCH_PATIENT);
         }
     }, [patient, navigate]);
     return <>{children}</>;