Skip to content

[PRMP-1640] Write out original NHS Number in BulkUploadReport Table#1217

Draft
robg-test wants to merge 1 commit intomainfrom
PRMP-1640
Draft

[PRMP-1640] Write out original NHS Number in BulkUploadReport Table#1217
robg-test wants to merge 1 commit intomainfrom
PRMP-1640

Conversation

@robg-test
Copy link
Contributor

@robg-test robg-test commented Mar 26, 2026

Overview

Jira ticket: PRMP-1640

Description

There is a bug with the BulkUploadReport where because NHS numbers on pre-processor failure where the NHS Number could not be derived it sets to 00000000 this breaks the Bulk Upload report because the counts it uses for patient is done based on the NHS Number, it needs to not do this and instead write whatever was sent to the BulkUploadReport.

Context

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit, e2e and smoke tests passing:

Additional tasks for UI changes (delete if not applicable):

  • 1. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

@robg-test robg-test requested review from a team as code owners March 26, 2026 16:50
@robg-test robg-test closed this Mar 26, 2026
@robg-test robg-test reopened this Mar 26, 2026
@robg-test robg-test marked this pull request as draft March 26, 2026 16:50
@robg-test robg-test changed the title [PRMP-1640] Write out original NHS Number in BulkUploadReport Table a… [PRMP-1640] Write out original NHS Number in BulkUploadReport Table Mar 26, 2026
@sonarqubecloud
Copy link

@github-actions
Copy link

Code security issues found

View full details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant