[PRMP-1330] - Add service-updates-link to footer #491
Conversation
oliverbeumkes-nhs
dismissed
their stale review
I didn't realise this was a draft
app/src/components/generic/serviceUpdatesLink/ServiceUpdatesLink.tsx
Outdated
Show resolved
Hide resolved
abid-nhs
left a comment
abid-nhs
left a comment
There was a problem hiding this comment.
It would be worthwhile modifying Footer.test.txs to have the first test/it block to check all the links are present
| > | ||
| Privacy notice | ||
| </NHSFooter.ListItem> | ||
| <ServiceUpdatesLink /> |
There was a problem hiding this comment.
As discussed I was wondering if it would be worth making the <NHSFooter.ListItem for ServiceUpdatesLink in the same file rather than separate one like the privacy link Footer list item. This might help with consistency especially since the ServiceUpdatesLink might not be usable in other places as its made as a NHSFooter.listitem
There was a problem hiding this comment.
I have modified this to no longer use a component but rather a constant within the Footer.tsx
abid-nhs
left a comment
abid-nhs
left a comment
There was a problem hiding this comment.
looks good however cypress tests seems to be failing
4 participants
No description provided.