Skip to content

[PRMP-1239] NEW SERVICE updated to be New service #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverbeumkes-nhs merged 2 commits into from
Dec 20, 2024
Merged

[PRMP-1239] NEW SERVICE updated to be New service #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ede94a
PRMP-1239
mark-start-nhs Dec 17, 2024
99b87a3
for pr
mark-start-nhs Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/cypress/e2e/0-ndr-core-tests/homepage.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe('Home Page', () => {
});

it('displays service banner', { tags: 'regression' }, () => {
cy.get('.govuk-phase-banner__content__tag').should('have.text', 'New Service');
cy.get('.govuk-phase-banner__content__tag').should('have.text', 'New service');
cy.get('.govuk-phase-banner__text').should(
'have.text',
'Your feedback will help us to improve this service.',
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/layout/phaseBanner/PhaseBanner.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('PhaseBanner', () => {
it('renders PhaseBanner with content', () => {
renderComponent();

expect(screen.getByText('New Service')).toBeInTheDocument();
expect(screen.getByText('New service')).toBeInTheDocument();

expect(screen.getByText(/Your/i)).toBeInTheDocument();
expect(screen.getByText(/feedback/i)).toBeInTheDocument();
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/layout/phaseBanner/PhaseBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function PhaseBanner() {
<div className="nhsuk-width-container">
<div className="govuk-phase-banner__content">
<strong className="govuk-tag govuk-phase-banner__content__tag">
New Service
New service
</strong>
<p className="govuk-phase-banner__text">
Your {linkToFeedbackPage} will help us to improve this service.
Expand Down
4 changes: 4 additions & 0 deletions app/src/styles/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,10 @@ $hunit: '%';
border: none;
}

.govuk-phase-banner__content__tag {
text-transform: none;
}

.govuk-warning-text__icon {
border: 3px solid $color_nhsuk-yellow;
background: $color_nhsuk-yellow;
Expand Down
Loading