Skip to content

[PRMP-589] Create SearchDocumentReview lambda logic #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steph-torres-nhs merged 86 commits into from
Nov 27, 2025
Merged

[PRMP-589] Create SearchDocumentReview lambda logic #864

steph-torres-nhs merged 86 commits into from
Nov 27, 2025

Conversation

@steph-torres-nhs
Copy link
Contributor

@steph-torres-nhs steph-torres-nhs commented Nov 3, 2025 •
edited
Loading

Description

Introduce Lambda Handler and relevant service to search for documents pending review by custodian
Jira ticket PRMP-589

Context

Part of Review feature, allowing users to search for review items to be sent to frontend

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
    - [ ] I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.
  • A member of all teams has approved this PR if there is a major code change. (If this is a minor change and you are confident this is not necessary then you may accept the standard approval process of 2 approvals from any teams.)
    https://github.com/NHSDigital/national-document-repository/actions/runs/19738725890

NogaNHS and others added 30 commits October 22, 2025 15:41
@NogaNHS
[PRMP-643] Add document review models and status enumeration
89fccdc
@NogaNHS
[PRMP-643] Refactor document review models and update document handli…
397eb0a 
…ng logic
@NogaNHS
[PRMP-643] update MNS service tests for document reviews
1b6ff81
@NogaNHS
Merge branch 'main' into PRMP-643
43975a1
@NogaNHS
set default model class to DocumentReference in fetch_documents method
81727f4
@NogaNHS
Merge branch 'main' into PRMP-643
e403c16
@NogaNHS
Update document review model and status enumeration
65f132e 
- Change ID field to use UUID as default value
- Update review status to use PENDING_REVIEW instead of PENDING
- Add new status values: PENDING_REVIEW and APPROVED
@NogaNHS
Refactor update_patient_ods_code to remove unnecessary table parameter
d713065
@NogaNHS
Merge branch 'main' into PRMP-643
88b2f1e
@NogaNHS
Refactor type hints to use union operator for document return types
03309bb
@NogaNHS
Merge branch 'main' into PRMP-643
d0a9d61
@NogaNHS
[PRMP-643] PR comments
88a3a6c
@NogaNHS
[PRMP-643] Implement DocumentReferenceService and DocumentUploadRevie…
7af8e60 
…wService for handling document operations
@NogaNHS
[PRMP-643] Fix parameter names in document service fetch calls for co…
6cc2a43 
…nsistency
@NogaNHS
[PRMP-643] Add unit tests for DocumentUploadReviewService and update …
ef5149a 
…MNSNotificationService mocks
@NogaNHS
[PRMP-643] Add unit tests for DocumentReferenceService and update Doc…
8b97a84 
…umentUploadReviewService tests
@NogaNHS
[PRMP-643] format
fb1a8be
@NogaNHS
[PRMP-643] Add mock environment variables for DocumentUploadReviewSer…
4af40b3 
…vice tests
@NogaNHS
[PRMP-643]Update mock environment variable for DocumentReviewService …
887b193 
…tests
@steph-torres-nhs
[PRMP-589] start implementation of querying table with ods code
4e8d6fd
@steph-torres-nhs
[PRMP-589] search document service calls dynamo with correct table an…
3b81cdd 
…d ods code
@steph-torres-nhs
[PRMP-589] format
1b5be45
@steph-torres-nhs
[PRMP-589] merge in PRMP-643
29817d4
@steph-torres-nhs
[PRMP-589] dynamo service can take limit a query param
5f6c7c6
@steph-torres-nhs
[PRMP-589] dynamo queried with both limit and ods code
c3e2d4f
@steph-torres-nhs
[PRMP-589] service returns doc review references and last evaluated key
739c551
@steph-torres-nhs
[PRMP-589] service returns empty list no documents found, none if not…
a01b0b7 
… last evaluated key
@steph-torres-nhs
[PRMP-589] error raised on validation error
91a1a51
@steph-torres-nhs
[PRMP-589] handler returns 400 response no ods in request context
fc5bc6c
@steph-torres-nhs
[PRMP-589] implement 200 and 500 handler response
3a0fd2a
megan-bower4
megan-bower4 reviewed Nov 27, 2025
View reviewed changes
@megan-bower4
Copy link
Contributor

megan-bower4 commented Nov 27, 2025

Could you just add a link to the sandbox run in the description please?

megan-bower4
megan-bower4 previously approved these changes Nov 27, 2025
View reviewed changes
@steph-torres-nhs steph-torres-nhs enabled auto-merge (squash) November 27, 2025 16:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@steph-torres-nhs steph-torres-nhs merged commit 6aa6b58 into main Nov 27, 2025
20 checks passed
@steph-torres-nhs steph-torres-nhs deleted the PRMP-589 branch November 27, 2025 16:51
@steph-torres-nhs steph-torres-nhs restored the PRMP-589 branch November 27, 2025 16:59
@steph-torres-nhs steph-torres-nhs deleted the PRMP-589 branch November 27, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lillie-dae lillie-dae lillie-dae approved these changes

@NogaNHS NogaNHS NogaNHS approved these changes

@megan-bower4 megan-bower4 megan-bower4 left review comments

@SteveMahoneyNHS SteveMahoneyNHS Awaiting requested review from SteveMahoneyNHS SteveMahoneyNHS is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@steph-torres-nhs @megan-bower4 @lillie-dae @NogaNHS @DuncanSangsterNHS