Skip to content

[PRMP-588] document review patch endpoint #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NogaNHS merged 32 commits into from
Dec 9, 2025

Refactor document review service tests to use 'version' consistently …

9646ccf
Select commit
Loading
Failed to load commit list.
Merged

[PRMP-588] document review patch endpoint #870

Refactor document review service tests to use 'version' consistently …
9646ccf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 9, 2025 in 46s

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
93.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 168 in lambdas/services/document_upload_review_service.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Failed to update document review" 3 times. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZqglfCE1MpWiwRucNif&open=AZqglfCE1MpWiwRucNif&pullRequest=870
View more details on SonarQubeCloud