Skip to content

[NDR-314] Move PDM tests. #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jameslinnell merged 8 commits into from
Nov 21, 2025
Merged

[NDR-314] Move PDM tests. #884

jameslinnell merged 8 commits into from
Nov 21, 2025

Conversation

@jameslinnell
Copy link
Contributor

@jameslinnell jameslinnell commented Nov 14, 2025 •
edited
Loading

Description

This moves any pdm unit tests into their own files.

Context

Separate out PDM from NDR for clarity

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.

@jameslinnell jameslinnell requested review from a team as code owners November 14, 2025 16:49
megan-bower4
megan-bower4 reviewed Nov 19, 2025
View reviewed changes
megan-bower4
megan-bower4 reviewed Nov 19, 2025
View reviewed changes
@megan-bower4
Copy link
Contributor

megan-bower4 commented Nov 19, 2025

Is it worth adding a make command that can run the pdm tests in isolation? make test-unit-pdm (or whatever the current pattern is)

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jameslinnell jameslinnell merged commit d719a41 into main Nov 21, 2025
27 of 28 checks passed
@jameslinnell jameslinnell deleted the NDR-314 branch November 21, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@megan-bower4 megan-bower4 megan-bower4 approved these changes

@tim-knight-nhs tim-knight-nhs tim-knight-nhs approved these changes

@SanjayChopraNHS SanjayChopraNHS Awaiting requested review from SanjayChopraNHS SanjayChopraNHS is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslinnell @megan-bower4 @tim-knight-nhs