Skip to content

[PRMP-541] Enforce virus scans on expedite files #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PedroSoaresNHS merged 16 commits into from
Nov 27, 2025
Merged

[PRMP-541] Enforce virus scans on expedite files #886

PedroSoaresNHS merged 16 commits into from
Nov 27, 2025

Conversation

@PedroSoaresNHS
Copy link
Contributor

@PedroSoaresNHS PedroSoaresNHS commented Nov 17, 2025 •
edited
Loading

Description

Added a verification to bulk_upload_metadata_service to determine if the expedited file had been scanned before
If the file had not been scanned then called the scanner
Refactored code, by removing logic from the handler to the service

Context

It makes it so that every processed file has passed by the virus scanner

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.
  • A member of all teams has approved this PR if there is a major code change. (If this is a minor change and you are confident this is not necessary then you may accept the standard approval process of 2 approvals from any teams.)

@PedroSoaresNHS
[PRMP-541] add verification that the file was scanned successfully
00b2c40
@PedroSoaresNHS
Merge remote-tracking branch 'origin/main' into PRMP-541
7258557 
# Conflicts:
#	lambdas/handlers/bulk_upload_metadata_processor_handler.py
#	lambdas/tests/unit/handlers/test_bulk_upload_metadata_processor_handler.py
SWhyteAnswer
SWhyteAnswer previously approved these changes Nov 21, 2025
View reviewed changes
@PedroSoaresNHS
Merge remote-tracking branch 'origin/main' into PRMP-541
1077f36 
# Conflicts:
#	lambdas/services/bulk_upload_metadata_processor_service.py
@PedroSoaresNHS
[PRMP-541] fixed imports
0072648
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@PedroSoaresNHS PedroSoaresNHS merged commit f806f20 into main Nov 27, 2025
18 checks passed
@PedroSoaresNHS PedroSoaresNHS deleted the PRMP-541 branch November 27, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwhitingnhs adamwhitingnhs adamwhitingnhs approved these changes

@SWhyteAnswer SWhyteAnswer SWhyteAnswer left review comments

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS MohammadIqbalAD-NHS left review comments

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

+1 more reviewer

@SanjayChopraNHS SanjayChopraNHS SanjayChopraNHS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PedroSoaresNHS @SWhyteAnswer @MohammadIqbalAD-NHS @adamwhitingnhs @SanjayChopraNHS