-
Notifications
You must be signed in to change notification settings - Fork 1
[PRM-605] Update .github/PULL_REQUEST_TEMPLATE.md (Jira link & checkboxes) #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d245cd
[PRM-605] Update .github/PULL_REQUEST_TEMPLATE.md (Jira link & checkb…
chrisbloe 5dd930f
More PR checkbox refinement
chrisbloe c21bc14
Merge branch 'main' into PRM-605
chrisbloe d3d1df6
Revise pull request template structure and content
chrisbloe c50f728
Merge branch 'main' into PRM-605
chrisbloe decedb9
Enhance PR template with description and context
chrisbloe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,40 @@ | ||
| <!-- markdownlint-disable-next-line first-line-heading --> | ||
| ## Overview | ||
|
|
||
| ## Description | ||
| **Jira ticket**: [TBC](https://nhsd-jira.digital.nhs.uk/browse/XXX) | ||
|
|
||
| ### Description | ||
|
|
||
| <!-- Describe your changes in detail. --> | ||
|
|
||
| ## Context | ||
| ### Context | ||
|
|
||
| <!-- Why is this change required? What problem does it solve? --> | ||
|
|
||
| ## Checklist | ||
|
|
||
| <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!-- | ||
|
|
||
| Put an `x` in the completed tasks. | ||
|
|
||
| If a task is not relevant, `x` it, then strike through the text e.g.: | ||
| - [x] ~~This task is not relevant.~~ | ||
|
|
||
| --> | ||
|
|
||
| Tasks for all changes: | ||
|
|
||
| - [ ] 1. I have linked this PR to its Jira ticket. | ||
| - [x] 2. ~~I have run git pre-commits.~~ (WIP) | ||
| - [ ] 3. I have added and/or updated relevant tests. | ||
| - [ ] 4. I have updated relevant documentation. | ||
| - [ ] 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary). | ||
| - [ ] 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing: | ||
| - [ ] 6a. [`Deploy - Sandbox`](https://github.com/NHSDigital/national-document-repository-infrastructure/actions/workflows/deploy-sandbox.yml) - [workflow run - TBC](https://github.com/NHSDigital/national-document-repository-infrastructure/actions/runs/XXX) | ||
| - [ ] 6b. [`SANDBOX Full- Deploy feature branch to sandbox`](https://github.com/NHSDigital/national-document-repository/actions/workflows/full-deploy-to-sandbox.yml) - [workflow run - TBC](https://github.com/NHSDigital/national-document-repository/actions/runs/XXX) | ||
|
|
||
| - [ ] I have followed the code style of the project. | ||
| - [ ] I have added tests to cover my changes. | ||
| - [ ] I have updated the documentation accordingly. | ||
| - [ ] I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected. | ||
| - [ ] I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully. | ||
| - [ ] A member of all teams has approved this PR if there is a major code change. (If this is a minor change and you are confident this is not necessary then you may accept the standard approval process of 2 approvals from any teams.) | ||
| Additional tasks for UI changes (delete if not applicable): | ||
|
|
||
| --- | ||
| - [ ] 1. I have run the UI Smoke Tests against the deployed sandbox and witnessed it passing: | ||
| - [ ] 1a. [`SANDBOX - UI Smoke Test`](https://github.com/NHSDigital/national-document-repository/actions/workflows/ui-smoketest.yml) - [workflow run - TBC](https://github.com/NHSDigital/national-document-repository/actions/runs/XXX) | ||
| - [ ] 2. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes. | ||
chrisbloe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.