Skip to content

[PRMP-540] Extract file information and Validate 1 of 1 file format and general processing #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MohammadIqbalAD-NHS merged 24 commits into from
Nov 27, 2025
Merged

[PRMP-540] Extract file information and Validate 1 of 1 file format and general processing #888

MohammadIqbalAD-NHS merged 24 commits into from
Nov 27, 2025

Conversation

@MohammadIqbalAD-NHS
Copy link
Contributor

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS commented Nov 19, 2025 •
edited
Loading

Description

Ticket: PRMP-540

Context

Scan on Demand expedite files must be validated using the general processing flow. Expedite files must be 1of1.

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.
  • A member of all teams has approved this PR if there is a major code change. (If this is a minor change and you are confident this is not necessary then you may accept the standard approval process of 2 approvals from any teams.)

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS marked this pull request as ready for review November 20, 2025 09:25
@MohammadIqbalAD-NHS MohammadIqbalAD-NHS requested review from a team as code owners November 20, 2025 09:25
PedroSoaresNHS
PedroSoaresNHS reviewed Nov 20, 2025
View reviewed changes
PedroSoaresNHS
PedroSoaresNHS reviewed Nov 20, 2025
View reviewed changes
PedroSoaresNHS
PedroSoaresNHS previously approved these changes Nov 21, 2025
View reviewed changes
PedroSoaresNHS
PedroSoaresNHS previously approved these changes Nov 21, 2025
View reviewed changes
@MohammadIqbalAD-NHS
Merge remote-tracking branch 'origin/main' into PRMP-540
ca40e80 
# Conflicts:
#	lambdas/handlers/bulk_upload_metadata_processor_handler.py
#	lambdas/services/bulk_upload_metadata_processor_service.py
#	lambdas/tests/unit/handlers/test_bulk_upload_metadata_processor_handler.py
#	lambdas/tests/unit/services/test_bulk_upload_metadata_processor_service.py
@MohammadIqbalAD-NHS
[PRMP-540] - Fix unit test post-merge conflicts
c71ce42
@MohammadIqbalAD-NHS
[PRMP-540] - Fix unit tests
3d729e7
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

robg-test
robg-test approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@robg-test robg-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs additional testing but want this in release to test expedite e2e

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS merged commit bdd8923 into main Nov 27, 2025
19 checks passed
@MohammadIqbalAD-NHS MohammadIqbalAD-NHS deleted the PRMP-540 branch November 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robg-test robg-test robg-test approved these changes

@PedroSoaresNHS PedroSoaresNHS PedroSoaresNHS approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

+1 more reviewer

@SanjayChopraNHS SanjayChopraNHS SanjayChopraNHS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MohammadIqbalAD-NHS @robg-test @PedroSoaresNHS @SanjayChopraNHS