Skip to content

Conversation

@megan-bower4
Copy link
Contributor

@megan-bower4 megan-bower4 commented Nov 19, 2025

Description

NDR-294
Refactoring the fhir search E2E tests so that they identify the created resource, rather than all that relate to the given NHS number. This makes them more robust if there is ever left over data in the database.

Context

The search tests were giving unreliable results when run multiple times with other data in the db.

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.
    https://github.com/NHSDigital/national-document-repository/actions/runs/19533351116 Run the E2E tests from this branch against ndr-dev
  • A member of all teams has approved this PR if there is a major code change. (If this is a minor change and you are confident this is not necessary then you may accept the standard approval process of 2 approvals from any teams.)

tim-knight-nhs
tim-knight-nhs previously approved these changes Nov 19, 2025
@github-actions
Copy link

Code security issues found

View full details here.

@sonarqubecloud
Copy link

@megan-bower4 megan-bower4 merged commit 4088ce3 into main Nov 21, 2025
17 of 18 checks passed
@megan-bower4 megan-bower4 deleted the NDR-294 branch November 21, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants