Skip to content

[NDR-286] Set search to return an empty bundle with no results #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jameslinnell merged 5 commits into from
Nov 21, 2025
Merged

[NDR-286] Set search to return an empty bundle with no results #897

jameslinnell merged 5 commits into from
Nov 21, 2025

Conversation

@jameslinnell
Copy link
Contributor

@jameslinnell jameslinnell commented Nov 21, 2025 •
edited
Loading

Description

No document references found for a valid NHS ID should return an empty bundle.

Context

Proviously it returned a 404 not found.

Checklist

  • I have followed the code style of the project.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have considered the cross-team impact when creating this PR and where possible written tests to validate for all affected.
  • I have built a sandbox with code from this PR and ensured the unit tests and end-to-end tests have run successfully.

@jameslinnell jameslinnell requested review from a team as code owners November 21, 2025 09:16
@megan-bower4
Copy link
Contributor

megan-bower4 commented Nov 21, 2025

LGTM - touches shared code though so would get a review from demographic too :)

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jameslinnell jameslinnell merged commit 2cc7d71 into main Nov 21, 2025
17 of 18 checks passed
@jameslinnell jameslinnell deleted the NDR-286 branch November 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewpotter2-nhs matthewpotter2-nhs matthewpotter2-nhs approved these changes

@megan-bower4 megan-bower4 megan-bower4 approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslinnell @megan-bower4 @matthewpotter2-nhs