Skip to content

[NDR-315] Code enhancements #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jameslinnell merged 3 commits into from
Jan 8, 2026
Merged

[NDR-315] Code enhancements #978

jameslinnell merged 3 commits into from
Jan 8, 2026

Conversation

@jameslinnell
Copy link
Contributor

@jameslinnell jameslinnell commented Jan 2, 2026

Overview

Jira ticket: NDR-315

Description

Just some minor changes to make the code more readable.

Context

When the fix in NDR-310 was introduced it was a bit rushed to fix it quickly.

Checklist

Tasks for all changes:

  • [1] 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits.
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

@jameslinnell jameslinnell requested review from a team as code owners January 2, 2026 16:38
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jameslinnell jameslinnell merged commit 78790c1 into main Jan 8, 2026
18 of 19 checks passed
@jameslinnell jameslinnell deleted the NDR-315 branch January 8, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@megan-bower4 megan-bower4 megan-bower4 approved these changes

@tim-knight-nhs tim-knight-nhs tim-knight-nhs approved these changes

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslinnell @megan-bower4 @tim-knight-nhs