Skip to content

Conversation

@NogaNHS
Copy link
Contributor

@NogaNHS NogaNHS commented Jan 5, 2026

Overview

Jira ticket: PRMP-915

Description

Refactored the download report functionality to support review report type. Added functionality for downloading the ODS review summary report on the ReviewsPage. Includes relevant new tests.

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

Additional tasks for UI changes (delete if not applicable):

  • 2. I have added evidence (to the jira ticket) e.g. screenshots/gifs of all visual changes.

@NogaNHS NogaNHS requested review from a team as code owners January 5, 2026 16:27
@NogaNHS NogaNHS changed the title [PRMP-915] Refactor download report feature to support dynamic report types [PRMP-915] download report feature to support review report Jan 5, 2026
adamwhitingnhs
adamwhitingnhs previously approved these changes Jan 5, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

vi.restoreAllMocks();
});

it('should fetch the report url from the API and trigger link click', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be parameterised/test both report scenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants