[PRMP-915] download report feature to support review report #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NogaNHS
changed the title
adamwhitingnhs
previously approved these changes
Jan 5, 2026
| vi.restoreAllMocks(); | ||
| }); | ||
|
|
||
| it('should fetch the report url from the API and trigger link click', async () => { |
Contributor
There was a problem hiding this comment.
should these be parameterised/test both report scenarios?
adamwhitingnhs
previously approved these changes
Jan 9, 2026
adamwhitingnhs
previously approved these changes
Jan 9, 2026
lillie-dae
previously approved these changes
Jan 12, 2026
| </p> | ||
|
|
||
| <Table.Panel heading="Documents to review" className="reviews-page" allowFullScreen> | ||
| <div className="mb-3" style={{ textAlign: 'right' }}> |
Contributor
There was a problem hiding this comment.
We shouldn't be using inline styles.
you could use class "nhsuk-u-text-align-right"
… types and add tests for download link
…lter in test_ods_report_service.py
NogaNHS
dismissed stale reviews from lillie-dae and adamwhitingnhs
via
56d7594
Code security issues foundView full details here. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-915
Description
Refactored the download report functionality to support review report type. Added functionality for downloading the ODS review summary report on the
ReviewsPage. Includes relevant new tests.Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)SANDBOX Full- Deploy feature branch to sandbox- workflow run - 20720089225Additional tasks for UI changes (delete if not applicable):