Skip to content

[PRMP-1182] Dont activate Kill Switch on Error #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PedroSoaresNHS wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PRMP-1182] Dont activate Kill Switch on Error #984

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cba7d2a
[PRMP-1182] updated transfer kill switch to not activate on Error
PedroSoaresNHS Jan 6, 2026
edd031c
[PRMP-1182] added tests
PedroSoaresNHS Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions lambdas/services/expedite_transfer_family_kill_switch_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
logger = LoggingService(__name__)

EXPECTED_SCAN_RESULTS = {"Infected", "Error", "Unscannable", "Suspicious"}
STOP_WORTHY_SCAN_RESULTS = {"Infected", "Unscannable", "Suspicious"}



def response(message: str):
Expand All @@ -29,29 +31,22 @@ def handle_sns_event(self, event: dict):

server_id = self.get_transfer_server_id()
if not server_id:
logger.warning(
"No Transfer Family server ID resolved from AWS – kill switch disabled."
)
return {
"statusCode": 200,
"body": json.dumps(
{
"message": (
"Transfer family kill switch disabled – no Transfer server ID discovered"
)
}
),
}
logger.warning("No Transfer Family server ID resolved from AWS – kill switch disabled.")
return response("Transfer family kill switch disabled – no Transfer server ID discovered")

logger.warning(
"Initiating Transfer Family shutdown.",
{
"server_id": server_id,
"workspace": self.workspace,
},
)
message = self.extract_sns_message(event)
if not message:
logger.error("Unable to parse SNS message JSON; not taking action")
return response("Invalid SNS message; no action taken")

return self.stop_transfer_family_server(server_id)
scan_result = message.get("scanResult")

if scan_result in STOP_WORTHY_SCAN_RESULTS:
logger.warning("Stopping Transfer Family due to scan result", {"scanResult": scan_result})
return self.stop_transfer_family_server(server_id)

logger.info("Scan result not actionable; no kill switch action", {"scanResult": scan_result})
return response("No action taken")

def handle_scan_message(self, server_id: str, message: dict):
scan_result = message.get("scanResult")
Expand Down
Loading