added posts on all.

RossBugginsNHS · RossBugginsNHS · commit e7ceded7bf88 · 2025-10-22T16:47:05.000Z
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,13 +1,23 @@
 {
-  "image": "mcr.microsoft.com/devcontainers/typescript-node:4.0.1-22-bullseye",
-   "features": {
+    "image": "mcr.microsoft.com/devcontainers/typescript-node:4.0.1-22-bullseye",
+    "features": {
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
             "azureDnsAutoDetection": true,
             "dockerDashComposeVersion": "latest",
             "installDockerBuildx": true,
             "installDockerComposeSwitch": true,
             "moby": true,
             "version": "latest"
+        },
+        "ghcr.io/devcontainers/features/common-utils:2.5.4": {
+            "configureZshAsDefaultShell": true,
+            "installOhMyZsh": true,
+            "installOhMyZshConfig": true,
+            "installZsh": true,
+            "upgradePackages": true,
+            "userGid": "automatic",
+            "userUid": "automatic",
+            "username": "automatic"
         }
     }
 }
diff --git a/src/devcontainers/base/.devcontainer/devcontainer.json b/src/devcontainers/base/.devcontainer/devcontainer.json
@@ -1,8 +1,11 @@
 {
-    "build": {
+
+    "name": "NHS Notify Default Base Developer Container",
+    "postCreateCommand": "echo Base Created",
+    "postStartCommand": "echo Base Started",
+        "build": {
         "dockerfile": "Dockerfile"
     },
-    "name": "NHS Notify Default Base Developer Container",
     "runArgs": [
         "--platform=linux/amd64"
     ]
diff --git a/src/devcontainers/base/Makefile b/src/devcontainers/base/Makefile
@@ -7,4 +7,5 @@ build:
 	devcontainer build \
 	--push false \
 	--workspace-folder $(WORKSPACE_FOLDER) \
-	--image-name "$(IMAGE_NAME)"
+	--image-name "$(IMAGE_NAME)" \
+	--label "devcontainer.metadata=[{\"containerEnv\": { \"NOTIFY_USE_BASE\": \"true\" }}]"
diff --git a/src/devcontainers/default/.devcontainer/devcontainer.json b/src/devcontainers/default/.devcontainer/devcontainer.json
@@ -1,5 +1,11 @@
 {
+    "name": "NHS Notify Default Developer Container",
     "image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-base:latest",
+    "postCreateCommand": "echo Default Created",
+    "postStartCommand": "echo Default Started",
+    "runArgs": [
+        "--platform=linux/amd64"
+    ],
     "features": {
         "ghcr.io/devcontainers/features/python:1.7.1": {
             "version": "3.13.8",
@@ -41,6 +47,5 @@
         "ghcr.io/devcontainers/features/go:1.3.2": {
             "version": "1.25.3"
         }
-    },
-    "name": "NHS Notify Default Developer Container"
+    }
 }
diff --git a/src/devcontainers/default/Makefile b/src/devcontainers/default/Makefile
@@ -8,5 +8,5 @@ build:
 	--push false \
 	--workspace-folder $(WORKSPACE_FOLDER) \
 	--image-name "$(IMAGE_NAME)" \
-	--label "devcontainer.metadata=[{\"containerEnv\": { \"CUSTOM_VARIABLE\": \"Testing a variable\" }}]"
+	--label "devcontainer.metadata=[{\"containerEnv\": { \"NOTIFY_USE_DEFAULT\": \"true\" }}]"
 
diff --git a/src/devcontainers/loaded/.devcontainer/devcontainer.json b/src/devcontainers/loaded/.devcontainer/devcontainer.json
@@ -1,6 +1,8 @@
 {
     "name": "NHS Notify Fully Loaded Developer Container",
     "image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-default:latest",
+    "postCreateCommand": "echo Loaded Created",
+    "postStartCommand": "echo Loaded Started",
     "features": {
         "ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.11": {
         }
diff --git a/src/devcontainers/loaded/Makefile b/src/devcontainers/loaded/Makefile
@@ -8,5 +8,5 @@ build:
 	--push false \
 	--workspace-folder $(WORKSPACE_FOLDER) \
 	--image-name "$(IMAGE_NAME)" \
-	--label "devcontainer.metadata=[{\"containerEnv\": { \"CUSTOM_VARIABLE\": \"Testing a variable\" }}]"
+	--label "devcontainer.metadata=[{\"containerEnv\": { \"NOTIFY_USE_LOADED\": \"true\" }}]"
 

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,11 @@`
`1`	`1`	`{`
`2`		`- "build": {`
	`2`	`+`
	`3`	`+ "name": "NHS Notify Default Base Developer Container",`
	`4`	`+ "postCreateCommand": "echo Base Created",`
	`5`	`+ "postStartCommand": "echo Base Started",`
	`6`	`+ "build": {`
`3`	`7`	`"dockerfile": "Dockerfile"`
`4`	`8`	`},`
`5`		`- "name": "NHS Notify Default Base Developer Container",`
`6`	`9`	`"runArgs": [`
`7`	`10`	`"--platform=linux/amd64"`
`8`	`11`	`]`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,11 @@`
`1`	`1`	`{`
	`2`	`+ "name": "NHS Notify Default Developer Container",`
`2`	`3`	`"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-base:latest",`
	`4`	`+ "postCreateCommand": "echo Default Created",`
	`5`	`+ "postStartCommand": "echo Default Started",`
	`6`	`+ "runArgs": [`
	`7`	`+ "--platform=linux/amd64"`
	`8`	`+ ],`
`3`	`9`	`"features": {`
`4`	`10`	`"ghcr.io/devcontainers/features/python:1.7.1": {`
`5`	`11`	`"version": "3.13.8",`
`@@ -41,6 +47,5 @@`
`41`	`47`	`"ghcr.io/devcontainers/features/go:1.3.2": {`
`42`	`48`	`"version": "1.25.3"`
`43`	`49`	`}`
`44`		`- },`
`45`		`- "name": "NHS Notify Default Developer Container"`
	`50`	`+ }`
`46`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "NHS Notify Fully Loaded Developer Container",`
`3`	`3`	`"image": "ghcr.io/nhsdigital/nhs-notify-devcontainer-default:latest",`
	`4`	`+ "postCreateCommand": "echo Loaded Created",`
	`5`	`+ "postStartCommand": "echo Loaded Started",`
`4`	`6`	`"features": {`
`5`	`7`	`"ghcr.io/nhsdigital/nhs-notify-devcontainers/nhsnotify:1.0.11": {`
`6`	`8`	`}`