generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
CCM-12896: Use Generated Event Types and Validators in Lambdas #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb60bd3 to
05e3d66
Compare
10 tasks
Ian-Hodges
reviewed
Dec 10, 2025
lambdas/ttl-handle-expiry-lambda/src/apis/dynamodb-stream-handler.ts
Outdated
Show resolved
Hide resolved
Ian-Hodges
previously approved these changes
Dec 10, 2025
sidnhs
approved these changes
Dec 11, 2025
Ian-Hodges
approved these changes
Dec 11, 2025
tdroza-nhs
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #138, we now have auto-generated TypeScript types and JS validator code for all digital-letters events that we have produced schemas for. This PR updates all TypeScript code that uses manually-created Zod schemas for our events to use our new types and validation functions. The main changes are:
MESHInboxMessageDownloadedandItemEnqueuedtypesMESHInboxMessageDownloadedandItemDequeuedtypesContext
Using auto-generated types based on our JSON schemas, which are the source of truth for the digital letters event definitions, means that our code will always be using the correct shape for events published.
Validation
Verified the integration tests are working as expected:

After the latest set of changes was deployed, I used CloudWatch to verify events were being processed as expected.
The ttl-create lambda adding an entry to the table in DynamoDB and then publishing the

ItemEnqueuedevent:The ttl-handle-expiry lambda detecting the deletion of the entry from DynamoDB and sending the

ItemDequeuedevent:Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.